Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make xyz to 2D more robust (catch errors) #80

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Make xyz to 2D more robust (catch errors) #80

merged 2 commits into from
Mar 6, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Mar 6, 2019

Also added converter tests

@codecov
Copy link

codecov bot commented Mar 6, 2019 •
edited
Loading

Codecov Report

Merging #80 into master will increase coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #80      +/-   ##
=========================================
+ Coverage   41.06%   41.1%   +0.04%     
=========================================
  Files          22      22              
  Lines        4851    4885      +34     
  Branches     1256    1263       +7     
=========================================
+ Hits         1992    2008      +16     
- Misses       2544    2554      +10     
- Partials      315     323       +8
Impacted Files Coverage Δ
arc/species/xyz_to_2d.py 38.76% <42.85%> (-0.11%) ⬇️
arc/species/converter.py 80.89% <60%> (-6.71%) ⬇️
arc/reaction.py 42.35% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a16ecc...457c531. Read the comment docs.

@alongd alongd force-pushed the converter_tests branch from ac3d3f8 to f85b8e8 Compare March 6, 2019 02:30
@alongd
Tests: Added xyz to 2D tests to converterTest
457c531 
(some were unsuccessful and were commented out)
@alongd alongd force-pushed the converter_tests branch from f85b8e8 to 457c531 Compare March 6, 2019 02:47
@alongd alongd merged commit 2c00b1d into master Mar 6, 2019
@alongd alongd deleted the converter_tests branch March 6, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Module: Converter Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alongd